Thumbs are using stars permissions

<<

ryanmc

Posts: 38

Joined: Thu Oct 22, 2009 12:02 am

Location: .

Post Wed Oct 28, 2009 6:56 pm

Thumbs are using stars permissions

I have been looking into my problems with getting permissions working correctly and I have discovered that thumbs in both articles and comments are not using their own permissions, instead they are using the permissions for stars.

Here is what I found:
in the function render_thumb_comment_actual on line 395 you see this line
  Code:
$rules_comments = $post_data->rules_comments != "I" ? $post_data->rules_comments : $this->g->get_post_rule_value($rd_post_id, "rules_comments", "default_voterules_comments");

rules_comments is the database field for stars, recc_rules_comments is the database field for thumbs

It should look like this
  Code:
$rules_comments = $post_data->recc_rules_comments != "I" ? $post_data->recc_rules_comments : $this->g->get_post_rule_value($rd_post_id, "recc_rules_comments", "default_voterules_comments");


Also in the function render_thumb_article_actual on line 676 you see this line
  Code:
$rules_articles = $post_data->rules_articles != "I" ? $post_data->rules_articles : $this->g->get_post_rule_value($rd_post_id, "rules_articles", "default_voterules_articles");

again rules_articles is the database field for stars, recc_rules_articles is the database field for thumbs

It should look like this
  Code:
$rules_articles = $post_data->recc_rules_articles != "I" ? $post_data->recc_rules_articles : $this->g->get_post_rule_value($rd_post_id, "recc_rules_articles", "default_voterules_articles");


I have tested both of these changes and they seem to work.
Last edited by ryanmc on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
www.justechn.com
<<

MillaN

Site Admin

Posts: 1067

Joined: Tue May 13, 2008 12:38 pm

Post Thu Oct 29, 2009 9:50 am

Re: Thumbs are using stars permissions

Full thumbs rules are not yet implemented. It will be completed in 1.7.4 and 1.7.5.
Last edited by MillaN on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
Read this announcement:
http://forum.gdragon.info/viewtopic.php?f=6&t=398&p=1574
<<

ryanmc

Posts: 38

Joined: Thu Oct 22, 2009 12:02 am

Location: .

Post Mon Nov 23, 2009 6:04 pm

Re: Thumbs are using stars permissions

I just downloaded 1.7.7 and I noticed that these fixes have not been implemented. Are you still planning on fixing the thumb permissions? Or have you already done it in a different way that I did not notice?
Last edited by ryanmc on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
www.justechn.com
<<

MillaN

Site Admin

Posts: 1067

Joined: Tue May 13, 2008 12:38 pm

Post Mon Nov 23, 2009 7:17 pm

Re: Thumbs are using stars permissions

This is planned for next release.
Last edited by MillaN on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
Read this announcement:
http://forum.gdragon.info/viewtopic.php?f=6&t=398&p=1574
<<

ryanmc

Posts: 38

Joined: Thu Oct 22, 2009 12:02 am

Location: .

Post Mon Dec 14, 2009 4:16 pm

Re: Thumbs are using stars permissions

Did this get fix in the latest release?
Last edited by ryanmc on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
www.justechn.com
<<

ryanmc

Posts: 38

Joined: Thu Oct 22, 2009 12:02 am

Location: .

Post Thu Mar 04, 2010 5:04 pm

Re: Thumbs are using stars permissions

I just downloaded 1.8.4 and this bug still exists.
Last edited by ryanmc on Thu Jan 01, 1970 12:00 am, edited 0 times in total.
Reason: .
www.justechn.com

Return to Bug Reports

Who is online

Users browsing this forum: No registered users and 1 guest

Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software for blacklist.org.